[pull] master from mozilla:master - #508
Merged
Merged
Conversation
…g 1898053) Some PDFs open a marked content section inside a text object and never close it. Each section adds a nesting level in the text layer, so the DOM becomes deep enough to crash Chromium with a stack overflow. When extracting the text, the sections opened after the matching BT are now closed on ET. The marked content level is tracked per stream in both getTextContent and getOperatorList: the sections a stream left open are closed when it ends, and an unbalanced EMC is ignored.
Auto-close the marked content sections left open in a text object (bug 1898053)
For JPEG images that can be decoded natively, always return an Object with a consistent shape regardless of the marker data. Also, tweak a comment in `JpegImage.getTransferableImage` to avoid ambiguity. Finally, replace `TextEncoder` usage with our `stringToBytes` helper in a unit-test.
Improve `JpegImage.canUseImageDecoder` return value consistency
This potentially avoids creating a lot of "duplicate" `TextDecoder` instances when parsing/rendering longer PDF documents. For example, when rendering all 1310 pages of the `pdf.pdf` document (from the test-suite) this patch reduces the number of `TextDecoder` instances created by `stringToPDFString` from *over* `33 000` to just a single one.
…TextDecoder Cache the `TextDecoder` instances used by the `stringToPDFString` helper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )